Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS diagnostics page is displaying *all* options files for each context #54816

Closed
Tracked by #53876
pq opened this issue Feb 2, 2024 · 4 comments
Closed
Tracked by #53876

DAS diagnostics page is displaying *all* options files for each context #54816

pq opened this issue Feb 2, 2024 · 4 comments
Assignees
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@pq
Copy link
Member

pq commented Feb 2, 2024

For example:

image

Better if it only showed the one(s) associated w/ the contexRoot.

@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request analyzer-server labels Feb 2, 2024
@pq pq self-assigned this Feb 2, 2024
@pq
Copy link
Member Author

pq commented Feb 2, 2024

@bwilkerson
Copy link
Member

I'm not convinced that that's better. Why do you think it's a problem to show all of the analysis options files that are controlling the analysis of files within the context? It seems to me like a misrepresentation to imply that there's a single set of options for the whole context when there are multiple sets of options.

@pq
Copy link
Member Author

pq commented Feb 5, 2024

Why do you think it's a problem to show all of the analysis options files that are controlling the analysis of files within the context?

Sorry to be unclear. The issue is we're showing ALL the options files for ALL the contexts in each context.

In the example above, you can see options for the linter, meta, kernel, etc. all associated w/ the analyzer context.

@bwilkerson
Copy link
Member

Yes, sorry I missed that detail. We definitely don't want to be showing options files associated with other contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

2 participants