Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSStyleDeclaration.getPropertyValue() should not return null #5617

Closed
efortuna opened this issue Oct 3, 2012 · 3 comments
Closed

CSSStyleDeclaration.getPropertyValue() should not return null #5617

efortuna opened this issue Oct 3, 2012 · 3 comments
Milestone

Comments

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2012

This bug is a request for the corresponding change to the dartium code to make CSSStyleDeclaration.getPropertyValue return empty string if the returned value is actually null. This bug was originally Issue #2154, but with CL: https://codereview.chromium.org/11047008 I've made the fix for the dart2js version to work (returning an empty string). When we make this change in Dartium, we can remove the line in the html.status file:

[ $compiler == none && ($runtime == drt || $runtime == dartium) ]
cssstyledeclaration_test: Fail # INeed to make corresponding dartium change.

@DartBot
Copy link

DartBot commented Oct 3, 2012

This comment was originally written by [email protected]


Emily, as discussed in original bug I am not quite sure if we should we should deviate from WebKit here.

But technically it should be rather easy to implement, just want to have an explicit confirmation we decided to diverge from WebKit here.


Added NeedsInfo label.

@efortuna
Copy link
Contributor Author

efortuna commented Oct 3, 2012

Check out blois's comment here: http://code.google.com/p/dart/issues/detail?id=2154#c20 -- I thought we'd decided to return empty strings for consistency? I and the other Seattleites are available to chat about this whenever.


Added Triaged label.

@DartBot
Copy link

DartBot commented Oct 4, 2012

This comment was originally written by [email protected]


Set owner to [email protected].
Added Fixed label.

@efortuna efortuna added this to the M1 milestone Oct 4, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants