Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: No compile-time error when a named constructor's id duplicates that of another member #5893

Closed
DartBot opened this issue Oct 15, 2012 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Milestone

Comments

@DartBot
Copy link

DartBot commented Oct 15, 2012

This issue was originally filed by [email protected]


as resolution of issue #3040, spec now says:
A constructor name always begins with the name of its immediately enclosing class or interface, and may optionally be followed by a dot and an identifier id. It is a compile-time error if id is the name of a member declared in the immediately enclosing class.

However, the following co19 test executes without a hitch on VM r13643:
Language/07_Classes/6_Constructors_A01_t01

class C {
  var foo;
  C.foo();
}

main() {
  try {
    new C.foo();
  } catch (e){}
}

@dgrove
Copy link
Contributor

dgrove commented Oct 16, 2012

Added Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

Time to remove the legacy support.


Set owner to @mhausner.
Added this to the M2 milestone.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Oct 17, 2012

This comment was originally written by @mhausner


Enabled the existing check by default. Test now passes.


Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Oct 17, 2012
@DartBot DartBot added this to the M2 milestone Oct 17, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants