Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub should parse Dart code to do more validation before uploading #7198

Closed
nex3 opened this issue Dec 7, 2012 · 5 comments
Closed

Pub should parse Dart code to do more validation before uploading #7198

nex3 opened this issue Dec 7, 2012 · 5 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Dec 7, 2012

Pub should do various sorts of validation that requires Dart code to be parsed. In particular:

Errors:

* Part files in "lib" outside of "lib/src".

  • Non-"package:" imports in "bin".
  • Examples importing from "lib/src".
  • Dart code with relative imports to files that don't exist.
  • Dart code with "package:" imports to files in this package that don't exist.
  • Dart code with "package:" imports for packages that aren't in the pubspec.

Warnings:

* Dart files in "bin" without main() methods.

  • Non-"package:" imports in "test" or "example".
  • Imports in "test" or "example" that reach outside the package.
@munificent
Copy link
Member

Added this to the Later milestone.

@munificent
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#343.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants