-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The format of dart.lib in 64-bit Dart SDK (Windows) is 32 bit #7792
Comments
There is no support for 64-bit windows in Dart, and building on Windows with the --arch=x64 flag builds the ia32 version instead. It is unclear whether compiling the 64-bit version should work or not - the only bug about this has been marked fixed. (http://code.google.com/p/dart/issues/detail?id=1968). Removed Priority-Medium label. |
This comment was originally written by [email protected] I have the same problem of the reporter. I noticed another thing: dumpbin dart.lib /exports Finds all symbols with an underscore as a first latter, e.g., while the linker tries to find Could that be the root course for unresolved externals? |
This comment was originally written by [email protected] I modified the header to use a underscore in front "_Dart_False": Is there any way to fix this? Could compiling the lib myself fix the issue? This means I am not able to use our selfmade dart extension on Windows (:(, Mac/Linux works) as we definitely require 64-bit. |
Added C7 label. |
cc @iposva-google. |
Set owner to @mraleph. |
Unmarked this as being blocked by #1968. |
Just want to give a small update on this. I have started to look at this today and I have the first working build of X64 Dart VM on Windows. However it will still take a bit before we get into the state where it passes all the tests. There is a noticeable difference in ABI between Windows and *nix systems and ABI assumptions are scattered across different parts of runtime. d:\src\dart\dart\build\ReleaseX64>dumpbin /headers dart.exe PE signature found File Type: EXECUTABLE IMAGE FILE HEADER VALUES d:\src\dart\dart\build\ReleaseX64>dart test.dart |
Added Started label. |
Fix is under review: https://codereview.chromium.org/317773002/ |
Fixed by r37078. tools/build.py -a x64 runtime should now correctly build a working x64 Dart VM Added Fixed label. |
This comment was originally written by [email protected] Thank you very much for the fix. |
I just landed a fix so it's not yet in any released version. I am not sure how we should proceed with this. Bill & Rico: do we have a continuous builder that will produce a Win64 SDK? Can we / should we cherry pick the r37078 into a 1.5? Overall it's a safe change from my point of view. |
Bill found out that we already have continuous builds of Win64 SDK: http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/dartsdk-windows-x64-release.zip I verified that dart.exe and dart.lib included with these builds are indeed x64 now. @anja.gerstmair: these are the bleeding edge builds so they might not be stable yet, but you can try them out already without building your own Dart VM from source. If you decide to try them, please tell us if they work as expected. Thanks. |
This issue was originally filed by [email protected]
What steps will reproduce the problem?
to check the library format
-----
D:\Program\dart-sdk-x64\bin>dumpbin dart.lib /headers
Microsoft (R) COFF/PE Dumper Version 10.00.30319.01
Copyright (C) Microsoft Corporation. All rights reserved.
Dump of file dart.lib
File Type: LIBRARY
FILE HEADER VALUES
14C machine (x86)
---
What is the expected output? What do you see instead?
Expect to see (x64) version but see (x86)
What version of the product are you using? On what operating system?
dart-sdk 0.2.10.1_r16761, Win7
Please provide any additional information below.
I found this when I try to compile the sample_extension to 64 bit DLL. The MS Visual Studio complains "unresolved external symbol Dart_Null referenced in function sample_extension_Init". Yet it works perfect when I compile the sample_extension to 32 bit DLL.
The text was updated successfully, but these errors were encountered: