-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues with the code for this action and the new javascript interop #107
Comments
Likely related, we can call the |
cc @srujzs - we're having some trouble with some of the interop code; one method throws when we try and call it and one method doesn't seem to properly modify a javascript value. Perhaps due to javascript modules in some way? I've mostly worked around this in #108 but it would be nice to be able to call the normal github action apis. Happy to provide more details as necessary. |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#default_import I wanted to try out the different import, but couldn't figure how to regenerate |
Thanks for the response - sounds like there may be some things I can investigate wrt the imports.
You can re-compile the javascript and re-bundle it via running |
Ah I missed that - thanks! Changing the imports does get me past that error now. |
Thanks! W/ the import change I'm now able to assign a value to process |
Nice! I think you should be able to call |
I did not re-try that API. I believe that's from the |
Yeah, I think that's right. It looks like all it does is set the |
When trying the new (unpublished) latest patch release functionality we've run across a few issues.
in workflow files, sdk versions of3.0
will be passed to the action as3
, possibly due to javascript numerics. specifying'3.0'
(in quotes) will address this, but we may want to special case integers (3
=>3.0
)failures are very verbose (see below)TypeError: Cannot set property exitCode of [object Module] which has only a getter\n at Module.setFailed
)longer failure:
The text was updated successfully, but these errors were encountered: