Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.5.0-1 - browser tests fail to compile #1073

Closed
red010b37 opened this issue Sep 16, 2019 · 3 comments
Closed

2.5.0-1 - browser tests fail to compile #1073

red010b37 opened this issue Sep 16, 2019 · 3 comments

Comments

@red010b37
Copy link

red010b37 commented Sep 16, 2019 •
edited
Loading

OS: Linux
Dart: 2.5.0-1
Test: latest version

We were running browser tests in 2.4.1-1 fine.
Upgrading dart to 2.5.0-1 makes the compiler fail, rolling back to 2.4.1-1 makes it work again

Trace output:

Compiled 9,812,727 characters Dart to 2,308,165 characters JavaScript in 5.90 seconds
Dart file /tmp/dart_test_EWPRNI/runInBrowser.dart compiled to JavaScript: /tmp/dart_test_JNQXFV/test_GLCTFR/browser_test.dart.browser_test.dart.js

type '_WebSocketProtocolTransformer' is not a subtype of type 'StreamTransformer<Uint8List, dynamic>' of 'streamTransformer'

dart:async/stream.dart                                           Stream.transform
package:web_socket_channel/src/copy/web_socket_impl.dart 712:28  new WebSocketImpl.fromSocket
package:web_socket_channel/src/channel.dart 94:36                new WebSocketChannel
package:shelf_web_socket/src/web_socket_handler.dart 82:15       WebSocketHandler.handle.<fn>
package:shelf/shelf_io.dart 146:35                               _fromHttpRequest.onHijack.<fn>
package:stack_trace/src/stack_zone_specification.dart 129:26     StackZoneSpecification._registerUnaryCallback.<fn>.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 129:14     StackZoneSpecification._registerUnaryCallback.<fn>
dart:async/zone.dart 1132:38                                     _rootRunUnary
dart:async/zone.dart 1029:19                                     _CustomZone.runUnary
dart:async/future_impl.dart 137:18                               _FutureListener.handleValue
dart:async/future_impl.dart 678:45                               Future._propagateToListeners.handleValueCallback
dart:async/future_impl.dart 707:32                               Future._propagateToListeners
dart:async/future_impl.dart 522:5                                Future._completeWithValue
dart:async/future_impl.dart 552:7                                Future._asyncComplete.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 119:48     StackZoneSpecification._registerCallback.<fn>
dart:async/zone.dart 1124:13                                     _rootRun
dart:async/zone.dart 1021:19                                     _CustomZone.run
dart:async/zone.dart 923:7                                       _CustomZone.runGuarded
dart:async/zone.dart 963:23                                      _CustomZone.bindCallbackGuarded.<fn>
dart:async/schedule_microtask.dart 41:21                         _microtaskLoop
dart:async/schedule_microtask.dart 50:5                          _startMicrotaskLoop
dart:isolate-patch/isolate_patch.dart 116:13                     _runPendingImmediateCallback
dart:isolate-patch/isolate_patch.dart 173:5                      _RawReceivePortImpl._handleMessage
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19                                     _CustomZone.registerUnaryCallback
dart:async/future_impl.dart 273:23                               Future.then
package:shelf/shelf_io.dart 146:10                               _fromHttpRequest.onHijack
package:shelf/src/request.dart 277:21                            _OnHijack.run.<fn>
package:shelf/src/util.dart 13:68                                newFuture.<fn>
package:stack_trace/src/stack_zone_specification.dart 129:26     StackZoneSpecification._registerUnaryCallback.<fn>.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 129:14     StackZoneSpecification._registerUnaryCallback.<fn>
dart:async/zone.dart 1132:38                                     _rootRunUnary
dart:async/zone.dart 1029:19                                     _CustomZone.runUnary
dart:async/future_impl.dart 137:18                               _FutureListener.handleValue
dart:async/future_impl.dart 678:45                               Future._propagateToListeners.handleValueCallback
dart:async/future_impl.dart 707:32                               Future._propagateToListeners
dart:async/future_impl.dart 522:5                                Future._completeWithValue
dart:async/future_impl.dart 552:7                                Future._asyncComplete.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 119:48     StackZoneSpecification._registerCallback.<fn>
dart:async/zone.dart 1124:13                                     _rootRun
dart:async/zone.dart 1021:19                                     _CustomZone.run
dart:async/zone.dart 923:7                                       _CustomZone.runGuarded
dart:async/zone.dart 963:23                                      _CustomZone.bindCallbackGuarded.<fn>
dart:async/schedule_microtask.dart 41:21                         _microtaskLoop
dart:async/schedule_microtask.dart 50:5                          _startMicrotaskLoop
dart:isolate-patch/isolate_patch.dart 116:13                     _runPendingImmediateCallback
dart:isolate-patch/isolate_patch.dart 173:5                      _RawReceivePortImpl._handleMessage
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19                                     _CustomZone.registerUnaryCallback
dart:async/future_impl.dart 273:23                               Future.then
package:shelf/src/util.dart 13:48                                newFuture
package:shelf/src/request.dart 277:5                             _OnHijack.run
package:shelf/src/request.dart 254:15                            Request.hijack
package:shelf_web_socket/src/web_socket_handler.dart 72:13       WebSocketHandler.handle
package:test/src/util/one_off_handler.dart 44:19                 OneOffHandler._onRequest
package:shelf/src/cascade.dart 72:44                             Cascade.handler.<fn>
package:shelf/src/cascade.dart 73:40                             Cascade.handler.<fn>.<fn>
dart:async/future.dart 224:31                                    new Future.sync
package:shelf/src/cascade.dart 73:21                             Cascade.handler.<fn>
package:shelf/src/cascade.dart 73:40                             Cascade.handler.<fn>.<fn>
dart:async/future.dart 224:31                                    new Future.sync
package:shelf/src/cascade.dart 73:21                             Cascade.handler.<fn>
package:shelf/src/cascade.dart 73:40                             Cascade.handler.<fn>.<fn>
dart:async/future.dart 224:31                                    new Future.sync
package:shelf/src/cascade.dart 73:21                             Cascade.handler.<fn>
package:shelf/src/cascade.dart 73:40                             Cascade.handler.<fn>.<fn>
dart:async/future.dart 224:31                                    new Future.sync
package:shelf/src/cascade.dart 73:21                             Cascade.handler.<fn>
package:test/src/util/path_handler.dart 53:19                    PathHandler._onRequest
package:shelf/src/cascade.dart 74:46                             Cascade.handler.<fn>.<fn>
package:stack_trace/src/stack_zone_specification.dart 129:26     StackZoneSpecification._registerUnaryCallback.<fn>.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 129:14     StackZoneSpecification._registerUnaryCallback.<fn>
dart:async/zone.dart 1132:38                                     _rootRunUnary
dart:async/zone.dart 1029:19                                     _CustomZone.runUnary
dart:async/future_impl.dart 137:18                               _FutureListener.handleValue
dart:async/future_impl.dart 678:45                               Future._propagateToListeners.handleValueCallback
dart:async/future_impl.dart 707:32                               Future._propagateToListeners
dart:async/future_impl.dart 387:9                                Future._addListener.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15     StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 119:48     StackZoneSpecification._registerCallback.<fn>
dart:async/zone.dart 1124:13                                     _rootRun
dart:async/zone.dart 1021:19                                     _CustomZone.run
dart:async/zone.dart 923:7                                       _CustomZone.runGuarded
dart:async/zone.dart 963:23                                      _CustomZone.bindCallbackGuarded.<fn>
dart:async/schedule_microtask.dart 41:21                         _microtaskLoop
dart:async/schedule_microtask.dart 50:5                          _startMicrotaskLoop
dart:isolate-patch/isolate_patch.dart 116:13                     _runPendingImmediateCallback
dart:isolate-patch/isolate_patch.dart 173:5                      _RawReceivePortImpl._handleMessage
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19                                     _CustomZone.registerUnaryCallback
dart:async/future_impl.dart 273:23                               Future.then
package:shelf/src/cascade.dart 73:58                             Cascade.handler.<fn>
package:shelf/shelf_io.dart 101:29                               handleRequest
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19                                     _CustomZone.registerUnaryCallback
dart:async/stream_impl.dart 139:21                               _BufferingStreamSubscription.onData
dart:async/stream_impl.dart 112:10                               new _BufferingStreamSubscription
dart:async/stream_controller.dart 838:9                          new _ControllerSubscription
dart:async/stream_controller.dart 670:51                         _StreamController._subscribe
dart:async/stream_controller.dart 818:19                         _ControllerStream._createSubscription
dart:async/stream_impl.dart 472:9                                _StreamImpl.listen
dart:_http/http_impl.dart 2673:31                                _HttpServer.listen
package:shelf/shelf_io.dart 63:14                                serveRequests.<fn>
package:shelf/src/util.dart 24:20                                catchTopLevelErrors
package:shelf/shelf_io.dart 62:3                                 serveRequests
package:shelf/src/io_server.dart 53:5                            IOServer.mount
package:test/src/runner/browser/platform.dart 153:13             new BrowserPlatform._
package:test/src/runner/browser/platform.dart 53:28              BrowserPlatform.start
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19                                     _CustomZone.registerUnaryCallback
dart:async-patch/async_patch.dart 71:23                          _asyncThenWrapperHelper
package:test/src/runner/browser/platform.dart                    BrowserPlatform.start
package:test/src/executable.dart 20:28                           main.<fn>
dart:async/future.dart 224:31                                    new Future.sync
package:async/src/async_memoizer.dart 43:45                      AsyncMemoizer.runOnce
package:test_core/src/runner/loader.dart 222:35                  Loader.loadFile.<fn>
===== asynchronous gap ===========================
dart:async/zone.dart 1045:19                                     _CustomZone.registerCallback
dart:async/zone.dart 962:22                                      _CustomZone.bindCallbackGuarded
dart:async/timer.dart 52:45                                      new Timer
dart:async/timer.dart 87:9                                       Timer.run
dart:async/future.dart 174:11                                    new Future
package:test_api/src/backend/invoker.dart 391:21                 Invoker._onRun.<fn>.<fn>.<fn>
@red010b37 red010b37 changed the title 2.5.0-1 - browser tests 2.5.0-1 - browser tests fail to compile Sep 16, 2019
@jakemac53
Copy link
Contributor

You need the latest web_socket_channel package, there was a breaking change in the latest SDK which doesn't affect much code but this was one package that was affected.

@jakemac53
Copy link
Contributor

dart-lang/sdk#36900 for reference

@red010b37
Copy link
Author

red010b37 commented Sep 24, 2019 •
edited
Loading

@jakemac53 - I think is is caused by the underlying shelf lib particularly - shelf_web_socket to be out of date with the WebSocketChannel lib, I have added a ticket here(dart-archive/shelf_web_socket#21), once complete are we able to update the self version.

I would assume this breaks a lot if not all of web/browser tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @red010b37