From 5d9cf03482cb9a1d1f6f7e8b846d804fb2692fe0 Mon Sep 17 00:00:00 2001
From: Kevin Moore <kevmoo@google.com>
Date: Sun, 3 Nov 2024 13:22:37 -0800
Subject: [PATCH] Fix analysis across packages

---
 pkgs/bazel_worker/analysis_options.yaml       | 4 ----
 pkgs/bazel_worker/e2e_test/pubspec.yaml       | 2 +-
 pkgs/bazel_worker/e2e_test/test/e2e_test.dart | 1 -
 pkgs/boolean_selector/analysis_options.yaml   | 1 -
 pkgs/coverage/analysis_options.yaml           | 1 -
 pkgs/graphs/analysis_options.yaml             | 1 -
 pkgs/json_rpc_2/analysis_options.yaml         | 1 -
 pkgs/mime/analysis_options.yaml               | 1 -
 pkgs/oauth2/analysis_options.yaml             | 1 -
 9 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/pkgs/bazel_worker/analysis_options.yaml b/pkgs/bazel_worker/analysis_options.yaml
index 9419b0985..264876473 100644
--- a/pkgs/bazel_worker/analysis_options.yaml
+++ b/pkgs/bazel_worker/analysis_options.yaml
@@ -7,7 +7,3 @@ analyzer:
   errors:
     # For the generated file
     lines_longer_than_80_chars: ignore
-
-linter:
-  rules:
-    - package_api_docs
diff --git a/pkgs/bazel_worker/e2e_test/pubspec.yaml b/pkgs/bazel_worker/e2e_test/pubspec.yaml
index d24a8e136..c97231f6a 100644
--- a/pkgs/bazel_worker/e2e_test/pubspec.yaml
+++ b/pkgs/bazel_worker/e2e_test/pubspec.yaml
@@ -9,7 +9,7 @@ dependencies:
     path: ../
 
 dev_dependencies:
-  cli_util: ^0.4.0
+  cli_util: ^0.4.2
   dart_flutter_team_lints: ^1.0.0
   path: ^1.8.0
   test: ^1.16.0
diff --git a/pkgs/bazel_worker/e2e_test/test/e2e_test.dart b/pkgs/bazel_worker/e2e_test/test/e2e_test.dart
index fa4c1a679..caa813a46 100644
--- a/pkgs/bazel_worker/e2e_test/test/e2e_test.dart
+++ b/pkgs/bazel_worker/e2e_test/test/e2e_test.dart
@@ -11,7 +11,6 @@ import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
 void main() {
-  var sdkPath = getSdkPath();
   var dart = p.join(sdkPath, 'bin', 'dart');
   runE2eTestForWorker('sync worker',
       () => Process.start(dart, [p.join('bin', 'sync_worker.dart')]));
diff --git a/pkgs/boolean_selector/analysis_options.yaml b/pkgs/boolean_selector/analysis_options.yaml
index 178039f53..af2619a08 100644
--- a/pkgs/boolean_selector/analysis_options.yaml
+++ b/pkgs/boolean_selector/analysis_options.yaml
@@ -4,4 +4,3 @@ linter:
   rules:
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
-    - package_api_docs
diff --git a/pkgs/coverage/analysis_options.yaml b/pkgs/coverage/analysis_options.yaml
index 1d9542ad3..82ce5e0a5 100644
--- a/pkgs/coverage/analysis_options.yaml
+++ b/pkgs/coverage/analysis_options.yaml
@@ -14,7 +14,6 @@ linter:
     - cancel_subscriptions
     - comment_references
     - literal_only_boolean_expressions
-    - package_api_docs
     - prefer_final_locals
     - sort_constructors_first
     - sort_unnamed_constructors_first
diff --git a/pkgs/graphs/analysis_options.yaml b/pkgs/graphs/analysis_options.yaml
index 19437b410..fcbc888d9 100644
--- a/pkgs/graphs/analysis_options.yaml
+++ b/pkgs/graphs/analysis_options.yaml
@@ -24,7 +24,6 @@ linter:
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - prefer_expression_function_bodies
     - prefer_final_locals
diff --git a/pkgs/json_rpc_2/analysis_options.yaml b/pkgs/json_rpc_2/analysis_options.yaml
index a91d5cace..295b7cc48 100644
--- a/pkgs/json_rpc_2/analysis_options.yaml
+++ b/pkgs/json_rpc_2/analysis_options.yaml
@@ -10,4 +10,3 @@ linter:
   rules:
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
-    - package_api_docs
diff --git a/pkgs/mime/analysis_options.yaml b/pkgs/mime/analysis_options.yaml
index 44b61cfdc..dc212e7d4 100644
--- a/pkgs/mime/analysis_options.yaml
+++ b/pkgs/mime/analysis_options.yaml
@@ -22,7 +22,6 @@ linter:
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - prefer_expression_function_bodies
     - prefer_final_locals
diff --git a/pkgs/oauth2/analysis_options.yaml b/pkgs/oauth2/analysis_options.yaml
index e21412ca6..a5f5ea451 100644
--- a/pkgs/oauth2/analysis_options.yaml
+++ b/pkgs/oauth2/analysis_options.yaml
@@ -17,7 +17,6 @@ linter:
     - literal_only_boolean_expressions
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - unnecessary_await_in_return
     - use_string_buffers