Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.callServiceExtension test failing for WebDev #2422

Closed
elliette opened this issue May 1, 2024 · 1 comment
Closed

.callServiceExtension test failing for WebDev #2422

elliette opened this issue May 1, 2024 · 1 comment

Comments

@elliette
Copy link
Contributor

elliette commented May 1, 2024

DWDS changed how it connects to the VM Service - via DDS instead of directly: #2388

As part of that change, the .callServiceExtension test case began failing for WebDev.

From what I see on #191, I'm not sure this is even necessary, since it was added to support Flutter (but Webdev is no longer(?) used to run Flutter apps).

I've tested Webdev locally and everything seems to be working, so I don't think it's a high priority to fix the test.

@elliette
Copy link
Contributor Author

elliette commented May 7, 2024

Figured out what the issue was, should be fixed in #2388

@elliette elliette closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant