Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globals are not exposed in the Debugger #2442

Open
elliette opened this issue May 30, 2024 · 3 comments
Open

globals are not exposed in the Debugger #2442

elliette opened this issue May 30, 2024 · 3 comments
Labels
P2 A bug or feature request we're likely to work on package:dwds triaged

Comments

@elliette
Copy link
Contributor

global Dart variables are not currently shown in the debugger.

@nshahan did some investigation and found we will likely need to request the globals for the current library. In Chrome DevTools, they are discoverable in a closure with the library name:

Screenshot 2024-05-30 at 10 06 34 AM
@nshahan
Copy link
Contributor

nshahan commented May 30, 2024

I'm anticipating there are some changes coming soon to the way DDC represents library global methods, getters, setters, and fields to support hot reload. This will likely need to be coordinated with dwds once we settle on a representation that works well. One idea is to use the same representation we use for class static methods, getters, setters, and fields so there might be an opportunity to reduce some of the logic required.

@bkonyi
Copy link
Collaborator

bkonyi commented Jul 31, 2024

@nshahan just to confirm, supporting accessing globals from the debugger will have to wait until after hot reload support is added to avoid having to change the implementation?

@bkonyi bkonyi added P2 A bug or feature request we're likely to work on triaged labels Jul 31, 2024
@nshahan
Copy link
Contributor

nshahan commented Jul 31, 2024

It's not a hard requirement to wait, but I just thought it would help you prioritize this work if you know that it will likely need to be revisited in the near future when the runtime representation of library globals changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on package:dwds triaged
Projects
None yet
Development

No branches or pull requests

3 participants