Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Rust toolchain action from actions-rs/toolchain to an action that is still maintained #1217

Open
SteveLauC opened this issue Aug 1, 2024 · 1 comment

Comments

@SteveLauC
Copy link
Collaborator

Just found that we are still using actions-rs/toolchain and actions-rs/cargo in the CI, they have already been archived, we should switch to an action that is maintained, e.g., dtolnay/rust-toolchain.

actions-rs/toolchain has an override parameter which is not provided by dtolnay/rust-toolchain, but we can do it manually:

      - name: Setup | Override toolchain
        run: rustup override set ${{ matrix.toolchain }}

actions-rs/cargo has a feature that is not supported by dtolnay/rust-toolchain as well, if we don't rely on this, we can simply invoke cargo manually:

  1. Warnings and errors issued by cargo will be displayed in GitHub UI
Copy link

github-actions bot commented Aug 1, 2024

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant