Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump rust to latest toolchain #11711

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 9, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

ci: Bump rust to latest toolchain

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 9, 2023 6:29am

@Xuanwo Xuanwo requested a review from everpcpc June 9, 2023 06:29
@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Jun 9, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 9, 2023

Nightly rust failed to build:

warning: build failed, waiting for other jobs to finish...
error: expected one of `)`, `,`, `.`, `?`, or an operator, found `:`
   --> src/query/functions/src/scalars/arithmetic.rs:111:31
    |
111 |               |a, b, _| (a.as_(): T) + (b.as_(): T),
    |                                 ^ expected one of `)`, `,`, `.`, `?`, or an operator
...
371 | /             with_integer_mapped_type!(|L| match left {
372 | |                 NumberDataType::L => with_integer_mapped_type!(|R| match right {
373 | |                     NumberDataType::R => {
374 | |                         register_basic_arithmetic!(L, R, registry);
...   |
378 | |                 _ => unreachable!(),
379 | |             });
    | |______________- in this macro invocation
    |
    = note: this error originates in the macro `register_plus` which comes from the expansion of the macro `with_integer_mapped_type` (in Nightly builds, run with -Z macro-backtrace for more info)

@Xuanwo Xuanwo marked this pull request as draft June 9, 2023 07:37
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 9, 2023

Convert to draft until we fix the regression.

@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Jun 11, 2023
@Xuanwo Xuanwo marked this pull request as ready for review June 25, 2023 06:56
@Xuanwo Xuanwo merged commit 3b57bd9 into databendlabs:main Jun 25, 2023
@Xuanwo Xuanwo deleted the bump-rust branch June 25, 2023 06:56
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants