Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix: perf maybe failed when run locally, issue #3689 #3690

Merged
merged 2 commits into from
Dec 29, 2021
Merged

[ci] Fix: perf maybe failed when run locally, issue #3689 #3690

merged 2 commits into from
Dec 29, 2021

Conversation

yihong0618
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Bug Fix
  • Build/Testing/CI
  • Documentation
  • Other
  • Not for changelog (changelog entry is not required)

Related Issues

#3689

Format some python code(delete unused code), and make code a bit pythonic
as use store_true instead of default "False"
image

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-bugfix this PR patches a bug in codebase pr-build this PR changes build/testing/ci steps pr-doc-fix labels Dec 29, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/DBqrpWz98MmzZavKnY6kJo8aehM6
✅ Preview: Canceled

[Deployment for 003a859 canceled]

@yihong0618 yihong0618 changed the title [ci]fix: perf maybe failed when run locally, issue #3689 [ci] Fix: perf maybe failed when run locally, issue #3689 Dec 29, 2021
@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #3690 (003a859) into main (1b6bf39) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3690   +/-   ##
=====================================
  Coverage     60%     60%           
=====================================
  Files        697     697           
  Lines      37230   37230           
=====================================
+ Hits       22382   22392   +10     
+ Misses     14848   14838   -10     
Impacted Files Coverage Δ
common/dal/src/context.rs 64% <0%> (-11%) ⬇️
common/management/src/cluster/cluster_mgr.rs 78% <0%> (-3%) ⬇️
common/streams/src/sources/source_parquet.rs 86% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (-1%) ⬇️
common/datavalues/src/columns/data_column.rs 71% <0%> (+<1%) ⬆️
query/src/common/mod.rs 85% <0%> (+14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6bf39...003a859. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @yihong0618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants