Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuse): add prewhere support in native storage format #9600

Merged
merged 17 commits into from
Jan 19, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 14, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. add prewhere support in native storage format
  2. add clustering page index in native storage format
  3. add page filter, this improves hits Q37 50% and other queries have no bad effects.
  4. bump opendal & strawboat
-- before
MySQL [(none)]> select  *  from hits_native where URL like '%google%' ignore_result;
Empty set (17.149 sec)


-- after
MySQL [(none)]> select  *  from hits_native where URL like '%google%' ignore_result;
Empty set (10.402 sec)

Closes #issue

@vercel
Copy link

vercel bot commented Jan 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 19, 2023 at 1:00AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 14, 2023
@BohuTANG
Copy link
Member

Will the prewhere also works for the fuse engine with parquet format?

@sundy-li
Copy link
Member Author

Will the prewhere also works for the fuse engine with parquet format?

No, just work on the native format.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 18, 2023

-- before
MySQL [(none)]> select * from hits_native where URL like '%google%' ignore_result;
Empty set (17.149 sec)

-- after
MySQL [(none)]> select * from hits_native where URL like '%google%' ignore_result;
Empty set (10.402 sec)

This bench is on local fs?

@Xuanwo
Copy link
Member

Xuanwo commented Jan 18, 2023

@sundy-li, opendal has released v0.25, can you bump to tagged version instead? Thanks.

@sundy-li
Copy link
Member Author

This bench is on local fs?

Yes,I'm focus on improving native format now.

@sundy-li
Copy link
Member Author

This bench is on local fs?

Yes,I'm focus on improving native format now. But I think it can also take effect on s3.

@BohuTANG BohuTANG merged commit e608589 into databendlabs:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants