From 55bc955304c4c192c04a0393a47355a295f5770a Mon Sep 17 00:00:00 2001
From: Harshal Sheth <hsheth2@gmail.com>
Date: Wed, 28 Feb 2024 09:49:58 -0800
Subject: [PATCH] feat(ci): skip smoke-test lint if there are no changes
 (#9945)

---
 .github/actions/ci-optimization/action.yml |  7 ++-
 .github/workflows/docker-unified.yml       | 50 ++++++++++------------
 2 files changed, 29 insertions(+), 28 deletions(-)

diff --git a/.github/actions/ci-optimization/action.yml b/.github/actions/ci-optimization/action.yml
index f6160fdbcff67..6bb389318c857 100644
--- a/.github/actions/ci-optimization/action.yml
+++ b/.github/actions/ci-optimization/action.yml
@@ -35,6 +35,9 @@ outputs:
   elasticsearch-setup-change:
     description: "Elasticsearch setup docker change"
     value: ${{ steps.filter.outputs.elasticsearch-setup == 'true' }}
+  smoke-test-change:
+    description: "Smoke test change"
+    value: ${{ steps.filter.outputs.smoke-test == 'true' }}
 runs:
   using: "composite"
   steps:
@@ -76,4 +79,6 @@ runs:
           postgres-setup:
             - "docker/postgres-setup/**"
           elasticsearch-setup:
-            - "docker/elasticsearch-setup/**"
\ No newline at end of file
+            - "docker/elasticsearch-setup/**"
+          smoke-test:
+            - "smoke-test/**"
diff --git a/.github/workflows/docker-unified.yml b/.github/workflows/docker-unified.yml
index 7c4742dbf8fc5..38ffa3484c0bf 100644
--- a/.github/workflows/docker-unified.yml
+++ b/.github/workflows/docker-unified.yml
@@ -29,35 +29,8 @@ env:
   DATAHUB_INGESTION_IMAGE: "acryldata/datahub-ingestion"
 
 jobs:
-  check_lint:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out the repo
-        uses: acryldata/sane-checkout-action@v3
-      - uses: actions/setup-python@v4
-        with:
-          python-version: "3.10"
-          cache: "pip"
-      - uses: actions/cache@v4
-        with:
-          path: |
-            ~/.cache/uv
-          key: ${{ runner.os }}-uv-${{ hashFiles('**/requirements.txt') }}
-      - name: Set up JDK 17
-        uses: actions/setup-java@v3
-        with:
-          distribution: "zulu"
-          java-version: 17
-      - uses: gradle/gradle-build-action@v2
-      - name: Ensure packages are correct
-        run: |
-          python ./.github/scripts/check_python_package.py
-      - name: Run lint on smoke test
-        run: |
-          ./gradlew :smoke-test:lint
   setup:
     runs-on: ubuntu-latest
-    needs: check_lint
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
       slim_tag: ${{ steps.tag.outputs.slim_tag }}
@@ -106,6 +79,29 @@ jobs:
           echo "publish=${{ env.ENABLE_PUBLISH }}" >> $GITHUB_OUTPUT
       - uses: ./.github/actions/ci-optimization
         id: ci-optimize
+      - uses: actions/setup-python@v4
+        if: ${{ steps.ci-optimize.outputs.smoke-test-change == 'true' }}
+        with:
+          python-version: "3.10"
+          cache: "pip"
+      - uses: actions/cache@v4
+        if: ${{ steps.ci-optimize.outputs.smoke-test-change == 'true' }}
+        with:
+          path: |
+            ~/.cache/uv
+          key: ${{ runner.os }}-uv-${{ hashFiles('**/requirements.txt') }}
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        if: ${{ steps.ci-optimize.outputs.smoke-test-change == 'true' }}
+        with:
+          distribution: "zulu"
+          java-version: 17
+      - uses: gradle/gradle-build-action@v2
+      - name: Run lint on smoke test
+        if: ${{ steps.ci-optimize.outputs.smoke-test-change == 'true' }}
+        run: |
+          python ./.github/scripts/check_python_package.py
+          ./gradlew :smoke-test:lint
 
   gms_build:
     name: Build and Push DataHub GMS Docker Image