Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not log out when using OIDC #4854

Closed
twuyts opened this issue May 6, 2022 · 13 comments
Closed

Can not log out when using OIDC #4854

twuyts opened this issue May 6, 2022 · 13 comments
Assignees
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX

Comments

@twuyts
Copy link

twuyts commented May 6, 2022

Describe the bug
I enabled OIDC authentication using Google. I can log in using my Google account. However, when I try to log out, I am immediately logged back in. There is no way of selecting a different account.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Google Authentication
  2. Log in
  3. select Logout in the top right dropdown menu
  4. you are redirected to the homepage and still logged in

Expected behavior
I would expect a page stating that I was logged out successfully, preferably with a link allowing me to log back in. When logging back in, I should be able to select the previous account, or use a different one.

Screenshots
logout

Desktop (please complete the following information):

  • OS: Ubuntu 20.04.4 LTS
  • Browser Firefox
  • Version 99.0 (64-bit)

Additional context
Same behaviour in other browsers.

@twuyts twuyts added the bug Bug report label May 6, 2022
@twuyts
Copy link
Author

twuyts commented May 6, 2022

might be related to #2735 ?

@xiphl
Copy link
Contributor

xiphl commented May 6, 2022

related to https://datahubspace.slack.com/archives/CV2UVAPPG/p1650916737226709.
i do get redirected to the keycloak login page in my case though.

@maggiehays maggiehays added the product PR or Issue related to the DataHub UI/UX label Jul 8, 2022
@jjoyce0510
Copy link
Collaborator

This there, can you please send the link for your Oidc Discovery URL? I want to confirm that it contains the "end_session_endpoint" param, which we use to log folks out when logout is clicked.

@jjoyce0510
Copy link
Collaborator

I notice that there is a revoke token endpoint present in some cases, which is not being used. My thought it that fixing this will be a matter of supporting token revocation, but still doing some investigation

@sunli1223
Copy link

I have a workaround solution, just only edit the code(change the href url)

<li class="ant-dropdown-menu-item ant-dropdown-menu-item-danger ant-dropdown-menu-item-only-child sc-pNWdM XJxhY" role="menuitem" tabindex="0" data-menu-id="rc-menu-uuid-97193-1-logout"><a href="/">Sign Out</a></li>

to

<li class="ant-dropdown-menu-item ant-dropdown-menu-item-danger ant-dropdown-menu-item-only-child sc-pNWdM XJxhY" role="menuitem" tabindex="0" data-menu-id="rc-menu-uuid-97193-1-logout"><a href="/logOut">Sign Out</a></li>

@pdraguiar
Copy link

I tested the workaround suggested by @sunli1223 and the problem was solved.

@jjoyce0510
Copy link
Collaborator

Thank you! I will raise a PR with this change.

@jjoyce0510
Copy link
Collaborator

This will be included in the next release.

Thanks for your input in helping solve this folks!

John

@vmm-afonso
Copy link

Currently running latest version v.0.13.2 and I'm still having this problem. I'm hitting Sign Out and I get redirected back to the home page. Is anyone else still having this issue?

@feder89
Copy link

feder89 commented May 8, 2024

Currently running latest version v.0.13.2 and I'm still having this problem. I'm hitting Sign Out and I get redirected back to the home page. Is anyone else still having this issue?

yes the same for me

@am2222
Copy link

am2222 commented May 24, 2024

The same issue on 0.13.2

@gtato
Copy link

gtato commented Jun 27, 2024

Same here (0.13.2), i think this issue needs to be reopned.

@livelace
Copy link

i've thought this issue fixed long ago (was a big break between datahub usage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

No branches or pull requests