-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not log out when using OIDC #4854
Comments
might be related to #2735 ? |
related to https://datahubspace.slack.com/archives/CV2UVAPPG/p1650916737226709. |
This there, can you please send the link for your Oidc Discovery URL? I want to confirm that it contains the "end_session_endpoint" param, which we use to log folks out when logout is clicked. |
I notice that there is a revoke token endpoint present in some cases, which is not being used. My thought it that fixing this will be a matter of supporting token revocation, but still doing some investigation |
I have a workaround solution, just only edit the code(change the href url) <li class="ant-dropdown-menu-item ant-dropdown-menu-item-danger ant-dropdown-menu-item-only-child sc-pNWdM XJxhY" role="menuitem" tabindex="0" data-menu-id="rc-menu-uuid-97193-1-logout"><a href="/">Sign Out</a></li> to <li class="ant-dropdown-menu-item ant-dropdown-menu-item-danger ant-dropdown-menu-item-only-child sc-pNWdM XJxhY" role="menuitem" tabindex="0" data-menu-id="rc-menu-uuid-97193-1-logout"><a href="/logOut">Sign Out</a></li> |
I tested the workaround suggested by @sunli1223 and the problem was solved. |
Thank you! I will raise a PR with this change. |
This will be included in the next release. Thanks for your input in helping solve this folks! John |
Currently running latest version v.0.13.2 and I'm still having this problem. I'm hitting Sign Out and I get redirected back to the home page. Is anyone else still having this issue? |
yes the same for me |
The same issue on |
Same here ( |
i've thought this issue fixed long ago (was a big break between datahub usage). |
Describe the bug
I enabled OIDC authentication using Google. I can log in using my Google account. However, when I try to log out, I am immediately logged back in. There is no way of selecting a different account.
To Reproduce
Steps to reproduce the behavior:
Logout
in the top right dropdown menuExpected behavior
I would expect a page stating that I was logged out successfully, preferably with a link allowing me to log back in. When logging back in, I should be able to select the previous account, or use a different one.
Screenshots
Desktop (please complete the following information):
Additional context
Same behaviour in other browsers.
The text was updated successfully, but these errors were encountered: