From b5f31010671dffb63cfb8cd06c67bc9c567b4fa6 Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Thu, 15 Dec 2022 22:25:52 +0530 Subject: [PATCH 1/3] docs(docker): add section for adding community images --- docker/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docker/README.md b/docker/README.md index 0905bb22ef1c1..e1079d51483d4 100644 --- a/docker/README.md +++ b/docker/README.md @@ -70,3 +70,6 @@ COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 docker-compose -p datahub build This is because we're relying on builtkit for multistage builds. It does not hurt also set `DATAHUB_VERSION` to something unique. +### Community Build Images + +As the open source project grows community members would like to contribute additions to the docker images. Not all contributions to the images can be accepted because those changes are not useful for all community members, it will increase build times, add dependencies and possible security vulns. In those cases this section can be used to point to `Dockerfiles` hosted by the community which build on top of the images published by the DataHub core team alongwith any container registry links where the result of those images are maintained. \ No newline at end of file From b352965e33c295b6592a745a54fa0a307c73c6a8 Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Thu, 15 Dec 2022 22:32:49 +0530 Subject: [PATCH 2/3] Update docker/README.md Co-authored-by: Harshal Sheth --- docker/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/README.md b/docker/README.md index e1079d51483d4..ab363e60dc577 100644 --- a/docker/README.md +++ b/docker/README.md @@ -70,6 +70,6 @@ COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 docker-compose -p datahub build This is because we're relying on builtkit for multistage builds. It does not hurt also set `DATAHUB_VERSION` to something unique. -### Community Build Images +### Community Built Images As the open source project grows community members would like to contribute additions to the docker images. Not all contributions to the images can be accepted because those changes are not useful for all community members, it will increase build times, add dependencies and possible security vulns. In those cases this section can be used to point to `Dockerfiles` hosted by the community which build on top of the images published by the DataHub core team alongwith any container registry links where the result of those images are maintained. \ No newline at end of file From 7e39a7a7add83e7f769c766780a4b4711dbaa444 Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Thu, 15 Dec 2022 22:32:57 +0530 Subject: [PATCH 3/3] Update docker/README.md Co-authored-by: Harshal Sheth --- docker/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/README.md b/docker/README.md index ab363e60dc577..831566c2e8174 100644 --- a/docker/README.md +++ b/docker/README.md @@ -72,4 +72,4 @@ something unique. ### Community Built Images -As the open source project grows community members would like to contribute additions to the docker images. Not all contributions to the images can be accepted because those changes are not useful for all community members, it will increase build times, add dependencies and possible security vulns. In those cases this section can be used to point to `Dockerfiles` hosted by the community which build on top of the images published by the DataHub core team alongwith any container registry links where the result of those images are maintained. \ No newline at end of file +As the open source project grows, community members would like to contribute additions to the docker images. Not all contributions to the images can be accepted because those changes are not useful for all community members, it will increase build times, add dependencies and possible security vulns. In those cases this section can be used to point to `Dockerfiles` hosted by the community which build on top of the images published by the DataHub core team along with any container registry links where the result of those images are maintained. \ No newline at end of file