From 93aae5eba9aecbaa8080a63145b98f599db9426d Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Thu, 29 Dec 2022 14:03:35 +0530 Subject: [PATCH 1/2] fix(ingest): okta undefined variable error --- metadata-ingestion/src/datahub/ingestion/source/identity/okta.py | 1 + 1 file changed, 1 insertion(+) diff --git a/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py b/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py index 7fe4ef71b541f..e32696a8fae16 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py +++ b/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py @@ -274,6 +274,7 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]: asyncio.set_event_loop(event_loop) # Step 1: Produce MetadataWorkUnits for CorpGroups. + okta_groups = None if self.config.ingest_groups: okta_groups = list(self._get_okta_groups(event_loop)) datahub_corp_group_snapshots = self._map_okta_groups(okta_groups) From 5d2491af3283f59bebad0bade0acb8ef7f98b74b Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Thu, 29 Dec 2022 18:09:19 +0530 Subject: [PATCH 2/2] add type info --- .../src/datahub/ingestion/source/identity/okta.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py b/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py index e32696a8fae16..239d8a3077a58 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py +++ b/metadata-ingestion/src/datahub/ingestion/source/identity/okta.py @@ -274,7 +274,7 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]: asyncio.set_event_loop(event_loop) # Step 1: Produce MetadataWorkUnits for CorpGroups. - okta_groups = None + okta_groups: Optional[Iterable[Group]] = None if self.config.ingest_groups: okta_groups = list(self._get_okta_groups(event_loop)) datahub_corp_group_snapshots = self._map_okta_groups(okta_groups)