Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide check dependency logic #83

Closed
guzman-raphael opened this issue Feb 23, 2021 · 2 comments · Fixed by #91
Closed

Hide check dependency logic #83

guzman-raphael opened this issue Feb 23, 2021 · 2 comments · Fixed by #91
Assignees
@Synicix
Labels
enhancement New feature or request high-priority
Milestone
Beta Release Cand...

Comments

@guzman-raphael
Copy link
Collaborator

guzman-raphael commented Feb 23, 2021 •
edited
Loading

Hide check dependency logic and issue delete as insert/update (which will use delete quick on backend).
Add proper handling to expect error and display parsed body to user with error details (records that could not be deleted).
@guzman-raphael guzman-raphael added this to the Beta Release Candidate milestone Feb 23, 2021
@guzman-raphael
Copy link
Collaborator Author

Depends on datajoint/pharus#86 being closed.

@Synicix Synicix added enhancement New feature or request high-priority labels Feb 25, 2021
@Synicix Synicix linked a pull request Feb 26, 2021 that will close this issue
fix insert error catch, add insert copy over #87
Merged
@guzman-raphael guzman-raphael removed a link to a pull request Feb 26, 2021
fix insert error catch, add insert copy over #87
Merged
@guzman-raphael guzman-raphael mentioned this issue Feb 26, 2021
Merged
@Synicix Synicix linked a pull request Feb 26, 2021 that will close this issue
Remove dependencies and fix bug with cancel button #91
Merged
@Synicix Synicix reopened this Feb 26, 2021
@Synicix
Copy link
Contributor

Synicix commented Feb 26, 2021

Not sure why this got closed, since we still have to do it for update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Synicix Synicix

Labels
enhancement New feature or request high-priority
Projects
None yet
Milestone
Beta Release Candidate
Development

Successfully merging a pull request may close this issue.

Remove dependencies and fix bug with cancel button Synicix/DJ-GUI-React
2 participants
@Synicix @guzman-raphael