Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema.save() does not handle part tables correctly #821

Closed
shenshan opened this issue Oct 24, 2020 · 4 comments
Closed

schema.save() does not handle part tables correctly #821

shenshan opened this issue Oct 24, 2020 · 4 comments

Comments

@shenshan
Copy link

image
It should be Segmentation.Roi

@dimitri-yatsenko
Copy link
Member

dimitri-yatsenko commented Oct 26, 2020

What does Trace.describe() indicate?

@ttngu207
Copy link
Contributor

ttngu207 commented Dec 9, 2020

I've encountered another bug in schema.save() - getting the name of part-table incorrectly

table = 'ephys_v2_analysis.__task_tracking__processed_tracking_member'

here, the part-table's class_name should be processed_tracking_member but was returned as the name of the master - task_tracking

Relevant code here:

class_name = class_name.split('__')[1]

In this block:

            if tier == 'Part':
                class_name = class_name.split('__')[1]
                indent += '    '

I believe should change to: class_name = class_name.split('__')[-1]

@ttngu207
Copy link
Contributor

ttngu207 commented Dec 9, 2020

@dimitri-yatsenko Do you think this fix can go as part of the 0.13 pre-release. I do need this fix quite urgently

@dimitri-yatsenko
Copy link
Member

Yep, will issue the PR today. Yes to include in 0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants