Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JEP for React.js at Jupyter #9

Closed
echarles opened this issue Feb 7, 2022 · 12 comments
Closed

[WIP] JEP for React.js at Jupyter #9

echarles opened this issue Feb 7, 2022 · 12 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@echarles
Copy link
Member

echarles commented Feb 7, 2022

This aims to create some content to be submitter as a JEP (Jupyter Enhancement Proposal) related to the usage of React.js in the Jupyter ecosystem.

The work preparation is being done in https://github.com/datalayer/jupyter-react/tree/jep/jep

Context:

@echarles echarles added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed and removed bug Something isn't working labels Feb 7, 2022
@echarles echarles changed the title JEP for React.js at Jupyter [WIP] JEP for React.js at Jupyter Feb 7, 2022
@echarles
Copy link
Member Author

echarles commented Feb 9, 2022

@fcollonval I have pushed some more content on https://github.com/datalayer/jupyter-react/tree/jep/jep based on the official JEP template and will further work tomorrow to have a first discussion basis.

In the meantime, feel free to scan the current state to see if we think in the same direction.

@echarles
Copy link
Member Author

echarles commented Feb 12, 2022

For now this inception JEP just focusses on landscape review and invitation for to the jupyter ecosystem to use the work being currently done in https://github.com/jupyterlab-contrib/jupyter-ui-toolkit.

To make it more clear, it may be wise to propose the migration to a top level repo hosted in e.g. https://github.com/jupyter/ui-components.

jupyter org because it aims any jupyter ui related project, ui-components because it delivers react.js components, web components... to build user interfaces.

WDYT @fcollonval @ellisonbg @jasongrout

@echarles
Copy link
Member Author

@afshin

@echarles
Copy link
Member Author

The npm packages are for now published under @jupyter-notebook, and https://github.com/jupyter-notebook having reserved a a GitHub org (I think I have read that some time ago), we could also discuss about the package name.

The proposal clearly mentions that the widgets should be spread for all kind of jupyter use cases, going beyond the notebook, @jupyter-notebook may be revisited. Ideally to the npm org @jupyter

@echarles
Copy link
Member Author

@krassowski may also be interested in this.

@fcollonval
Copy link
Member

One note about the naming on npm package. The jupyter organization is hold by someone already. I reached out to npmjs.org 5 months ago about options to transfer ownership of it. But I didn't get any answer.
The jupyter-notebook has been taken by @jtpio due to that. But definitely naming is not final.

@jtpio
Copy link

jtpio commented Feb 13, 2022

The npm packages are for now published under @jupyter-notebook, and https://github.com/jupyter-notebook having reserved a a GitHub org (I think I have read that some time ago), we could also discuss about the package name.

Linking to the following two issues for more context:

@echarles
Copy link
Member Author

Yes, I had read about that some time ago but didn't know the status of npmjs.org reply.

Package naming and repository location would be the final decision and we have to polish and brainstorm on this initial JEP content. Still good to propose in the proposal a generic GitHub and Npm name.

@echarles
Copy link
Member Author

@fcollonval @jtpio I think we have now a good basis to start the JEP pre-proposal process documented on https://jupyter.org/enhancement-proposals/jupyter-enhancement-proposal-guidelines/jupyter-enhancement-proposal-guidelines.html#jep-submission-workflow. Thx again for your inputs on work on this. I propose to shepherd the JEP and assign you in the review team. WDYT?

@fcollonval
Copy link
Member

Thanks @echarles to pushing on this.

Let's start the pre-proposal process

@echarles
Copy link
Member Author

Pre proposal opened on jupyter/enhancement-proposals#88

@echarles
Copy link
Member Author

Closing as a PR is now available for review in the official jupyter enhancement-proposals jupyter/enhancement-proposals#89.

Thx all for you contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants