Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFSP solving problem Q-Loss #319

Open
emanueleiacca opened this issue May 24, 2024 · 0 comments
Open

NFSP solving problem Q-Loss #319

emanueleiacca opened this issue May 24, 2024 · 0 comments

Comments

@emanueleiacca
Copy link

Hi, i'm sorry I don't know how to make a pull request, i am a noob in git :(
It has been 3 months since I'm working on RLCard for my bachelor degree thesis, rn I'm working on NFSP algorithm. I use Tensorboard to plot results and I was having problem to plot the loss, in the nfsp_agent.py code:
def feed(self, ts):
''' Feed data to inner RL agent

    Args:
        ts (list): A list of 5 elements that represent the transition.
    '''
    self._rl_agent.feed(ts)
    self.total_t += 1
    if self.total_t>0 and len(self._reservoir_buffer) >= self._min_buffer_size_to_learn and self.total_t%self._train_every == 0:
        sl_loss  = self.train_sl()
        print('\rINFO - Step {}, sl-loss: {}'.format(self.total_t, sl_loss), end='')

the function doesn't return the sl_loss, so this part should be added
return sl_loss
return None
Thank u very much for this wonderful project, I hope to help
Emanuele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant