Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add a method in ConfigEntry called create to support configurations with no default value #950

Closed
qqqttt123 opened this issue Dec 5, 2023 · 0 comments · Fixed by #1141
Closed

[Improvement] Add a method in ConfigEntry called create to support configurations with no default value #950

qqqttt123 opened this issue Dec 5, 2023 · 0 comments · Fixed by #1141
Assignees
@qqqttt123
Labels
improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@qqqttt123
Copy link
Contributor

What would you like to be improved?

Add a method in ConfigEntry called create to support configurations with no default value

How should we improve?

No response
@qqqttt123 qqqttt123 added the improvement Improvements on everything label Dec 5, 2023
@qqqttt123 qqqttt123 mentioned this issue Dec 5, 2023
Merged
@qqqttt123 qqqttt123 self-assigned this Dec 6, 2023
@qqqttt123 qqqttt123 mentioned this issue Dec 6, 2023
Closed
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Dec 13, 2023
[apache#950] improvment(common): Add a method in ConfigEntry called c…
4d1cd4b 
…reate to support configurations with no default value
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Dec 13, 2023
[apache#950] improvment(common): Add a method in ConfigEntry called c…
ece27ac 
…reate to support configurations with no default value
@qqqttt123 qqqttt123 mentioned this issue Dec 13, 2023
Merged
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Dec 13, 2023
[apache#950] improvment(common): Add a method in ConfigEntry called c…
7d4ad6d 
…reate to support configurations with no default value
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 14, 2023
jerryshao pushed a commit that referenced this issue Dec 20, 2023
@qqqttt123
[#950] improvment(common): Add a method in ConfigEntry called create …
fbce0fe 
…to support configurations with no default value (#1141)

### What changes were proposed in this pull request?
Some configuration options are necessary but don't have default value.

### Why are the changes needed?

Fix: #950 

### Does this PR introduce _any_ user-facing change?
Change some configuration options from `` to none


### How was this patch tested?
CI passed.

---------

Co-authored-by: Heng Qin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qqqttt123 qqqttt123

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
2 participants
@jerryshao @qqqttt123