Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning #1090

Closed
wants to merge 4 commits into from
Closed

Pinning #1090

wants to merge 4 commits into from

Conversation

RangerMauve
Copy link
Contributor

As per #1081, this adds the dat pin command.

This also deprecates the dat registry commands.

Some things I'd like feedback on in addition to the code:

  • Should I change any command names?
  • Should the pinning service only keep the latest files instead of the full history?
  • Was it a good idea to deprecate the registry stuff?

@joehand
Copy link
Collaborator

joehand commented Apr 1, 2019

(much more to review)

Can you make the config file location in dat-pin configurable, then set it explicitly in the CLI. This will make it easier to change it/make it an option.

EDIT: oops, it is already configurable. Can we set it also in the CLI? That way we dont have to dig down the dependency tree later to figure it out =)

@joehand joehand deleted the pinning branch June 19, 2019 00:20
@joehand joehand mentioned this pull request Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants