Fixed an NullReferenceException for F# projects

phmonte · Oct 31, 2022 · 071979f · 071979f
1 parent da86d32
commit 071979f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Buildalyzer/AnalyzerResult.cs b/src/Buildalyzer/AnalyzerResult.cs
@@ -90,7 +90,7 @@ public string GetProperty(string name) =>
                     && !string.Equals(Path.GetFileName(x.Item2), "csc.exe", StringComparison.OrdinalIgnoreCase))
                 .Select(x => AnalyzerManager.NormalizePath(Path.Combine(Path.GetDirectoryName(ProjectFilePath), x.Item2)))
                 .ToArray() ?? _fscCommandLineArguments
-                ?.Where(x => x.Item1 == null
+                ?.Where(x => x.Item1 == null && x.Item2 != null
                     && !x.Item2.Contains("fsc.dll")
                     && !x.Item2.Contains("fsc.exe"))
                 .Select(x => AnalyzerManager.NormalizePath(Path.Combine(Path.GetDirectoryName(ProjectFilePath), x.Item2)))

diff --git a/tests/Buildalyzer.Tests/Integration/SimpleProjectsFixture.cs b/tests/Buildalyzer.Tests/Integration/SimpleProjectsFixture.cs
@@ -557,6 +557,7 @@ public void BuildsFSharpProject()
 
             // Then
             results.Count.ShouldBeGreaterThan(0, log.ToString());
+            results.First().SourceFiles.ShouldNotBeNull();
             results.OverallSuccess.ShouldBeTrue(log.ToString());
             results.ShouldAllBe(x => x.Succeeded, log.ToString());
         }