Include functionality from scala-suffix-maven-plugin #469
makingthematrix
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
I'm writing apps in Scala for the Android platform. I use GraalVM Native Image, JavaFX, and Maven, so I couldn't do it without scala-maven-plugin. Thanks a lot :)
There is a problem, though. Since Java 9 the Scala way of putting the language version at the end of the library artifactId is not valid. It's easy to fix - basically, the creator of the library needs to add the Automatic-Module-Name property to the manifest file - but I guess the demand is so low nobody really cares. Another way to fix it is to go down to Java 8, but I can't do it because of JavaFX (and, frankly, I don't want to).
So I wrote a plugin: scala-suffix-maven-plugin which modifies the contents of the manifest file of given Scala libraries in the local Maven repository. You can check the description for more details on what is the problem and how it is fixed.
I'm willing to maintain the plugin and maybe even develop it further (although it's very simple, not much more to do there) but I thought that maybe you would be interested in adding it to scala-maven-plugin as an additional goal? If yes, I will make a PR. I wanted to ask you first because it will be a bit of work and maybe you prefer to keep this functionality separate.
(By the way, if yes, can I add vavr as a dependency?)
Cheers,
Maciek
Beta Was this translation helpful? Give feedback.
All reactions