Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing PR if it exists #56

Open
jesseduffield opened this issue May 3, 2023 · 3 comments
Open

Update existing PR if it exists #56

jesseduffield opened this issue May 3, 2023 · 3 comments

Comments

@jesseduffield
Copy link

Sometimes I'll create a release and then this action will create a PR for me (e.g. v5.0.0), and then I'll soon afterwards push a new release with a bugfix in it (e.g. v5.0.1). Currently, the action will fail due to an existing PR being present. I would instead like it to push a new commit to the existing PR with the updated formula.

I'm not sure if this is possible. If people think this behaviour shouldn't be enabled by default, perhaps it could be an optional flag

Also hope you're doing well @dawidd6 !

@jesseduffield
Copy link
Author

Ah, looks like the 'force' flag may be what I want. Though it's not clear from the documentation what that will do. Will it create a separate PR?

@dawidd6
Copy link
Owner

dawidd6 commented May 4, 2023

That would require a fair bit of coding in the action itself or upstream in Homebrew/brew. The force input corresponds to brew bump-formula-pr --force option which means:

-f, --force Ignore duplicate open PRs. Remove all mirrors if --mirror was not specified.

...which could be what you want, except you would then end up with two PRs being open at the same time (one for v5.0.0, second for v5.0.1) and that could annoy maintainers 😄 if you don't close the previous PR manually.

@jesseduffield
Copy link
Author

Ah, that makes sense, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants