Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update property to read when handling keyboard events #197

Closed
Gregg8 opened this issue Feb 21, 2019 · 1 comment
Closed

Update property to read when handling keyboard events #197

Gregg8 opened this issue Feb 21, 2019 · 1 comment
Labels
enhancement

Comments

@Gregg8
Copy link
Contributor

Gregg8 commented Feb 21, 2019

When determining what key was pressed in keyboard event handlers, we examine various properties:

  • which is used by drop-down, input-text and typeahead
  • keyCode is used by input-time

Both of these are now deprecated, so they should all be switched to use the key property - info

Thanks to: day8/re-frame-10x#231
@Frozenlock
Copy link
Contributor

Some additional info, in case it would be useful:

keyCode is supported by all browsers. (According to caniuse.com)

key not as much.
https://caniuse.com/#search=keyboardevent.key

@kimo-k kimo-k closed this as completed in dab03ef Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@superstructor @Frozenlock @Gregg8