Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Label NMS #339

Closed
Auth0rM0rgan opened this issue Feb 14, 2020 · 2 comments
Closed

Multi-Label NMS #339

Auth0rM0rgan opened this issue Feb 14, 2020 · 2 comments

Comments

@Auth0rM0rgan
Copy link

Auth0rM0rgan commented Feb 14, 2020

Hey @dbolya, I'm just curious to know, have you tried multi-label nms for Yolact? if yes, how was the performance compare to your proposed fast nms?
Based on this repo https://github.com/tianzhi0549/FCOS, they were able to speeds up ResNe(x)t based models by up to 30% and MobileNet based models by 40%, with exactly the same performance.

Thanks

@dbolya
Copy link
Owner

dbolya commented Feb 19, 2020

Their original implementation of NMS was incredibly inefficient, and their implementation of multi-label NMS made it faster because they implemented it efficiently, so sadly other approaches won't see the same speed-up.

Fast NMS is already multi-label (this is what we call traditional NMS in our paper). It's just an approximate way to do it. Their original NMS "single-label NMS" is what we call cross-class NMS and if implemented right, it's faster than multi-label.

You can see this here: tianzhi0549/FCOS#175 (comment)
YOLO implements by default (here multi_cls=False) cross-class nms or "single-label NMS" and it's faster (but has worse performance) than their "multi-label NMS" (here multi_cls=True).

You can also do Fast cross-class NMS, and as expected it's faster but does worse than Fast (multi-class) NMS. I recon the FCOS guys would see a nice speed improvement with only a small hit to performance if they used our Fast NMS (basically compare "traditional NMS" and "fast NMS" in the ablation table in our paper).

That's my impression, at least. Though, I might be understanding things wrong here.

@Auth0rM0rgan
Copy link
Author

@dbolya, Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants