[ADAP-638] [Bug] dbt crashes if for nested fields (e.g. struct) both the parent and subfields are defined in the YAML file
#782
Assignees
Labels
bug
Something isn't working
Comments
github-actions
bot
changed the title
struct) both the parent and subfields are defined in the YAML filestruct) both the parent and subfields are defined in the YAML file
|
@b-per Thanks for testing out, and for opening! From some quick local testing:
Agree that this is the ideal outcome! repro caseThis works: -- models/model_a.sql
select struct("blue" as field_1, 100 as field_2) as my_structmodels:
- name: model_a
config:
contract: {enforced: true}
materialized: table
columns:
- name: my_struct.field_1
data_type: string
constraints:
- type: not_null
description: Desc for field_1
- name: my_struct.field_2
data_type: integer
description: Desc for field_2Desirable outcome: models:
- name: model_a
config:
contract: {enforced: true}
columns:
- name: my_struct
description: My overall description
constraints:
- type: not_null
- name: my_struct.field_1
data_type: string
description: Desc for field_1
constraints:
- type: not_null
- name: my_struct.field_2
data_type: integer
description: Desc for field_2Should template SQL like: create or replace table `dbt-test-env`.`dbt_jcohen`.`model_a`
(
my_struct struct<field_1 string not null, field_2 integer> not null
)
OPTIONS()
as (
select my_struct
from (
select struct("blue" as field_1, 100 as field_2) as my_struct
) as model_subq
) |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a new bug in dbt-bigquery?
Current Behavior
While testing #738 in 1.5rc2, we managed to crash dbt when adding YML config to a struct, both at the parent and subfield levels at the same time.
The goal was to try:
not nullin addition to some of the subfields beingnot null(the following was tried with and without
data_typeat the parent level but both failed, with different errors though. in an ideal situation, we wouldn't have to set thedata_typeat the parent level but still be allowed to add constraint and documentation)We were expecting this to either work or get a config error from dbt but instead dbt crashes. The code dump is listed below.
Expected Behavior
I would expect this config not to crash but instead to:
Steps To Reproduce
a. at the subfield level
b. at the struct (e.g. parent level)
Relevant log output
Environment
- dbt-core: 1.5rc2Additional Context
No response
The text was updated successfully, but these errors were encountered: