Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIDY FIRST] Add typing to BaseRunner class #10606

Open
1 task done
QMalcolm opened this issue Aug 26, 2024 · 0 comments · May be fixed by #10607
Open
1 task done

[TIDY FIRST] Add typing to BaseRunner class #10606

QMalcolm opened this issue Aug 26, 2024 · 0 comments · May be fixed by #10607
Assignees

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

The BaseRunner class is largely untyped. Given the prevalence of this class, not having it typed could mean that there are potential edge cases and/or runtime exceptions we are not aware of. By typing this class, we give ourselves a lot more guarantees

Acceptance criteria

The BaseRunner class is fully typed

Suggested Tests

N/A

Impact to Other Teams

None

Will backports be required?

No

Context

I'm doing this as an example case for the Tech Improvement Tuesday we're having focused on typing improvements.

@QMalcolm QMalcolm added user docs [docs.getdbt.com] Needs better documentation and removed user docs [docs.getdbt.com] Needs better documentation labels Aug 26, 2024
@QMalcolm QMalcolm self-assigned this Aug 26, 2024
@QMalcolm QMalcolm linked a pull request Aug 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant