Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Bump protoc to v27 or v28 #10658

Open
1 task done
MichelleArk opened this issue Sep 3, 2024 · 1 comment · May be fixed by #10969
Open
1 task done

[Tech Debt] Bump protoc to v27 or v28 #10658

MichelleArk opened this issue Sep 3, 2024 · 1 comment · May be fixed by #10969
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

Currently we generate core_types_pb2.py using 5.26.1:

> protoc --version
libprotoc 26.1

This version is tricky to install via brew install protobuf, which is making it difficult for team members to use a consistent version locally when generating the file

Acceptance criteria

Suggested Tests

n/a

Impact to Other Teams

n/a

Will backports be required?

nope

Context

No response

@MichelleArk MichelleArk added user docs [docs.getdbt.com] Needs better documentation tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Sep 3, 2024
@DevonFulcher
Copy link
Contributor

DevonFulcher commented Oct 29, 2024

I was able to install protoc 26.1 pretty easily with asdf:

asdf plugin-add protoc https://github.com/paxosglobal/asdf-protoc.git
asdf install protoc 26.1
asdf local protoc 26.1

I agree, though. It makes senses to upgrade the version so it is easier with homebrew.
cc: @QMalcolm

@gshank gshank linked a pull request Nov 4, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants