[Bug] Console logs emitting CANCEL for the last model ran by each thread even if those models finished building when receiving SIGINT (CTRL+C) #10746
Labels
Comments
dbeatty10
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a new bug in dbt-core?
Current Behavior
When we CTRL+C a running dbt process - dbt emits
CANCELfor the last-ish ran model for each thread even if those models ran successfully. This causes some user confusion.Expected Behavior
Don't emit CANCEL in the console logs unless necessary.
Steps To Reproduce
Project setup:
Run with 2 threads, then cancel (CTRL+C) as we see model
estarting:^
dshows as both CANCEL and OK:With many threads and models, this can be confusing to some users.
Relevant log output
Environment
Which database adapter are you using with dbt?
postgres
Additional Context
run_results.jsonshows the true state as well where a, b, c, and d hasstatus: success{ "status": "success", "timing": [ { "name": "compile", "started_at": "2024-09-19T23:38:52.508408Z", "completed_at": "2024-09-19T23:38:52.512328Z" }, { "name": "execute", "started_at": "2024-09-19T23:38:52.530406Z", "completed_at": "2024-09-19T23:39:02.607688Z" } ], "thread_id": "Thread-1 (worker)", "execution_time": 10.100392818450928, "adapter_response": { "_message": "SELECT 1", "code": "SELECT", "rows_affected": 1 }, "message": "SELECT 1", "failures": null, "unique_id": "model.my_dbt_project.a", "compiled": true, "compiled_code": "select pg_sleep(10)::text as c", "relation_name": "\"postgres\".\"public\".\"a\"" }, { "status": "success", "timing": [ { "name": "compile", "started_at": "2024-09-19T23:38:52.511185Z", "completed_at": "2024-09-19T23:38:52.512160Z" }, { "name": "execute", "started_at": "2024-09-19T23:38:52.512474Z", "completed_at": "2024-09-19T23:39:02.609014Z" } ], "thread_id": "Thread-2 (worker)", "execution_time": 10.101626873016357, "adapter_response": { "_message": "SELECT 1", "code": "SELECT", "rows_affected": 1 }, "message": "SELECT 1", "failures": null, "unique_id": "model.my_dbt_project.b", "compiled": true, "compiled_code": "select pg_sleep(10)::text as c", "relation_name": "\"postgres\".\"public\".\"b\"" }, { "status": "success", "timing": [ { "name": "compile", "started_at": "2024-09-19T23:39:02.611820Z", "completed_at": "2024-09-19T23:39:02.613697Z" }, { "name": "execute", "started_at": "2024-09-19T23:39:02.614005Z", "completed_at": "2024-09-19T23:39:12.684779Z" } ], "thread_id": "Thread-1 (worker)", "execution_time": 10.073916912078857, "adapter_response": { "_message": "SELECT 1", "code": "SELECT", "rows_affected": 1 }, "message": "SELECT 1", "failures": null, "unique_id": "model.my_dbt_project.c", "compiled": true, "compiled_code": "select pg_sleep(10)::text as c", "relation_name": "\"postgres\".\"public\".\"c\"" }, { "status": "success", "timing": [ { "name": "compile", "started_at": "2024-09-19T23:39:02.612822Z", "completed_at": "2024-09-19T23:39:02.613851Z" }, { "name": "execute", "started_at": "2024-09-19T23:39:02.615928Z", "completed_at": "2024-09-19T23:39:12.685920Z" } ], "thread_id": "Thread-2 (worker)", "execution_time": 10.074712038040161, "adapter_response": { "_message": "SELECT 1", "code": "SELECT", "rows_affected": 1 }, "message": "SELECT 1", "failures": null, "unique_id": "model.my_dbt_project.d", "compiled": true, "compiled_code": "select pg_sleep(10)::text as c", "relation_name": "\"postgres\".\"public\".\"d\"" }Bonus:
Can we make
run_results.jsonalso record the fact that modeleerrored when the error was due to a cancel?The text was updated successfully, but these errors were encountered: