Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-719] Add Grants to Postgres Materializations #5329

Closed
nathaniel-may opened this issue Jun 2, 2022 · 1 comment · Fixed by #5369
Closed

[CT-719] Add Grants to Postgres Materializations #5329

nathaniel-may opened this issue Jun 2, 2022 · 1 comment · Fixed by #5369
Labels
adapter_plugins Issues relating to third-party adapter plugins enhancement New feature or request postgres

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Jun 2, 2022

blocked by: #5263

Once the above work is merged, there are some tweaks that need to be made in the Postgres adapter to fully expose the feature:
- [ ] for incremental, seed, and snapshot materializations call apply_grants(..., revoke=True)
- [ ] otherwise (i.e. view/table materializations) call apply_grants(..., revoke=False) for a performance improvement

@github-actions github-actions bot changed the title Add Grants to Postgres Materializations [CT-719] Add Grants to Postgres Materializations Jun 2, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 3, 2022

@McKnight-42 McKnight-42 mentioned this issue Jul 13, 2022
6 tasks
@jtcohen6 jtcohen6 added the adapter_plugins Issues relating to third-party adapter plugins label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter_plugins Issues relating to third-party adapter plugins enhancement New feature or request postgres
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants