Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2037] Parsing: model ‘deprecation_date’ attribute #6868

Closed
Tracked by #6747
MichelleArk opened this issue Feb 6, 2023 · 3 comments
Closed
Tracked by #6747

[CT-2037] Parsing: model ‘deprecation_date’ attribute #6868

MichelleArk opened this issue Feb 6, 2023 · 3 comments
Labels

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 6, 2023

Parse deprecation_date: Optional[str], as configured in a model yaml property file. Should be available as a model node attribute in the manifest.

Validation

  • deprecation_date should be a valid datetime format(potentially configurable at the project-level?) or a special ’never’/‘unplanned’ string value
  • All versioned models with latest:false must declare a deprecation_date.
  • Only versioned models can have a non-null deprecation_date
@github-actions github-actions bot changed the title Parsing: model ‘deprecation_date’ attribute [CT-2037] Parsing: model ‘deprecation_date’ attribute Feb 6, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 6, 2023

potentially configurable at the project-level?

Yeah, this would be a vote in favor of implementing deprecation_date as a standard config (unlike version or latest).

Only versioned models can have a non-null deprecation_date

I don't think we need to enforce this. While all non-latest versioned models must be deprecated, I think a model could declare its own forthcoming deprecation, even if it's not versioned.

Taken together, I think there's a fair argument for deprecation_date as a config. It's definitely related to version/latest, conceptually and for certain validation steps, but users could also make use of it independently of model versioning.

@emmyoop
Copy link
Member

emmyoop commented Mar 6, 2023

Will we throw an error if we are past the deprecation date? #6870 mentions warnings if the date exists but it's unclear what happens after the date is in the past.

@MichelleArk
Copy link
Contributor Author

Closing in favor of implementation issue: #7433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants