Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2040] Include model version in alias #6871

Closed
Tracked by #6747
MichelleArk opened this issue Feb 6, 2023 · 3 comments
Closed
Tracked by #6747

[CT-2040] Include model version in alias #6871

MichelleArk opened this issue Feb 6, 2023 · 3 comments

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 6, 2023

Update the default implementation of the generate_alias_name macro to add a _v{version} suffix, when a model version is available.

@github-actions github-actions bot changed the title Include model version in alias [CT-2040] Include model version in alias Feb 6, 2023
@emmyoop
Copy link
Member

emmyoop commented Mar 6, 2023

Will this need to be done in all/some of the adapters?

@emmyoop emmyoop added the Refinement Maintainer input needed label Mar 6, 2023
@jtcohen6
Copy link
Contributor

I'm envisioning logic like this, to replace what's there right now:

{% macro default__generate_alias_name(custom_alias_name=none, node=none) -%}
    {%- if custom_alias_name -%}
        {{ return(custom_alias_name | trim) }}
    {%- elif node.version -%}
        {{ return(node.name ~ "_v" ~ node.version) }}
    {%- else -%}
        {{ return(node.name) }}
    {%- endif -%}
{%- endmacro %}

No changes needed in adapters.

@MichelleArk
Copy link
Contributor Author

Closing in favor of #7263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants