-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2314] [Feature] Do we _have_ to call the boolean property contract
?
#7184
Comments
contract
?contract
?
@joellabes Thanks for opening ❤️
Very very true! Options:
In discussion with @aranke... or avoid the word
My initial intent in using |
I like |
Good conversation with @gwenwindflower @callum-mcdata @MichelleArk in Slack: Could we envision supporting other nested fields / configurations in the future? For example, during community office hours, there was an ask to make "enforcing column order" configurable. I don't think we're going to do that in the first cut—for simplicity, and because I don't think deterministic column order is high-value, and finally because column order necessarily changes to handle schema evolution for incremental models—but still, we could imagine other related configurations existing in the future. contract:
enforced: true
<more_things_in_future>: ... I prefer |
i also like contract in terms of pointing to where this is all headed. data contracts do indeed mean many things to many people, but this is one of the most common meanings. |
I disagree with how most data people use |
Totally happy with
! |
Is this your first time submitting a feature request?
Describe the feature
From reading #6748, it looks like I'm about 3 weeks late to this party. But better now than in another 3 weeks!
I haven't been following this closely, and when I saw
contract:
I assumed it was going to be the key of a dictionary containing all the rules of the contract, not a simple bool.Could I make a late breaking pitch for
has_contract
?Describe alternatives you've considered
is_contracted
, but I don't think I'll get as far on that one.contract_enabled
instead ofconstraints_enabled
)Who will this benefit?
People who assume we follow our style guide (yes I know this is the SQL style guide not the Python style guide, but it's going to be side-by-side with all the YAML that does follow this scheme)
Are you interested in contributing this feature?
I could if it's the only way it'll get done, but I won't be the fastest way to get it done
Anything else?
No response
The text was updated successfully, but these errors were encountered: