Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2625] Support model contracts + constraints with nested fields in core #7759

Open
Tracked by #7979 ...
MichelleArk opened this issue Jun 1, 2023 · 1 comment
Open
Tracked by #7979 ...
Labels
model_contracts multi_project tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

dbt-labs/dbt-bigquery#738 implemented model contract + constraint support for models with nested fields in BigQuery, but much of the implementation is not specific to any adapter. The adapter-specific piece relates to formatting the nested column type (so this bit).

BigQuery's support for nested columns is very thorough - supporting many levels of nesting (up to 100) and constraints on nested columns. Nested columns are not supported with the same maturity across various platforms and so it feels to early to be implement, test, and maintain this spec across all adapters. We could eventually revisit this though - and remove the need for the BigQuery adapter to implement overrides of get_empty_schema_sql and get_select_subquery macros.

@adamcunnington-mlg
Copy link

@jtcohen6 can I clarify whether this got supported in the end and if so, whether the docs were updated to show the syntax for adding a test on a struct column or a repeated column or complex combinations of these (struct of array of structs etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model_contracts multi_project tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

3 participants