Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2834] [Bug] Unable to convert deprecation warnings to errors #8130

Closed
2 tasks done
Tracked by #7372
dbeatty10 opened this issue Jul 18, 2023 · 0 comments · Fixed by #8129
Closed
2 tasks done
Tracked by #7372

[CT-2834] [Bug] Unable to convert deprecation warnings to errors #8130

dbeatty10 opened this issue Jul 18, 2023 · 0 comments · Fixed by #8129
Assignees
Labels
bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

PASSing console output and a zero exit code instead of the expected behavior below.

Expected Behavior

WARN_ERROR_OPTIONS gives a mechanism whereby users can promote these warnings to actual runtime errors, and I expected a red FAIL message in the console output and a non-zero exit code.

Steps To Reproduce

models/my_model.sql

{{ config(materialized="table") }}

select 0 as id

models/_models.yml

models:
  - name: my_model
    deprecation_date: 1999-01-01

I was hoping for both of these to error out and have a non-zero exit code:

dbt --warn-error run
echo $?

dbt --warn-error-options '{"include": ["DeprecatedModel"]}' run
echo $?

Relevant log output

No response

Environment

- OS:
- Python:
- dbt: 1.6.0rc1

Which database adapter are you using with dbt?

postgres

Additional Context

No response

@dbeatty10 dbeatty10 added bug Something isn't working triage pre-regression Regression not yet in a stable release labels Jul 18, 2023
@github-actions github-actions bot changed the title [Pre-regression] Unable to convert deprecation warnings to errors [CT-2834] [Pre-regression] Unable to convert deprecation warnings to errors Jul 18, 2023
@dbeatty10 dbeatty10 removed the triage label Jul 18, 2023
@MichelleArk MichelleArk self-assigned this Jul 18, 2023
@dbeatty10 dbeatty10 removed the pre-regression Regression not yet in a stable release label Jul 18, 2023
@dbeatty10 dbeatty10 changed the title [CT-2834] [Pre-regression] Unable to convert deprecation warnings to errors [CT-2834] [Bug] Unable to convert deprecation warnings to errors Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants