Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret JSON schema validator errors #822

Closed
beckjake opened this issue Jul 3, 2018 · 1 comment
Closed

Interpret JSON schema validator errors #822

beckjake opened this issue Jul 3, 2018 · 1 comment

Comments

@beckjake
Copy link
Contributor

beckjake commented Jul 3, 2018

As part of #820, I implemented an attempt to clean up the schema validation error output. It was pretty messy and involved a bunch of regex matches so we removed it.

Currently missing attributes each are a separate message, and extra attributes get combined into one. There is an actual object involved that lets you identify if it's an error about attributes being extra vs missing, but what attribute is extra or missing is only available as part of the error text itself. It would be nice to have it be consistent, one way or the other.

@drewbanin
Copy link
Contributor

drewbanin commented Nov 26, 2019

we don't use json schemas directly anymore and we do a pretty good job of rendering these error messages these days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants