Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2973] Fix untyped functions in semver.py (mypy warning) #8389

Closed
Tracked by #8387
emmyoop opened this issue Aug 14, 2023 · 0 comments · Fixed by #8416
Closed
Tracked by #8387

[CT-2973] Fix untyped functions in semver.py (mypy warning) #8389

emmyoop opened this issue Aug 14, 2023 · 0 comments · Fixed by #8416
Assignees
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Aug 14, 2023

Problem

When we hit a mypy error the console is flooded with mypy warnings as well. Clean up the warning to improve developer experience.

Reproduction

Simply force a mypy error (change types) and the warnings will be generated.

Relevant Output

core/dbt/semver.py:111: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
core/dbt/semver.py:112: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
@github-actions github-actions bot changed the title Fix untyped functions in semver.py (mypy warning) [CT-2973] Fix untyped functions in semver.py (mypy warning) Aug 14, 2023
@emmyoop emmyoop added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Aug 14, 2023
@gshank gshank self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants