Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3189] [Bug] make dev is broken due to dependency conflict #8789

Closed
2 tasks done
emmyoop opened this issue Oct 6, 2023 · 0 comments · Fixed by #8788
Closed
2 tasks done

[CT-3189] [Bug] make dev is broken due to dependency conflict #8789

emmyoop opened this issue Oct 6, 2023 · 0 comments · Fixed by #8788
Assignees
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Oct 6, 2023

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When installing dev dependencies you get a dependency conflict.

Expected Behavior

make dev installs everything without error

Steps To Reproduce

run make dev in a clean environemnt

Relevant log output

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behavior is the source of the following dependency conflicts.
types-requests 2.31.0.8 requires urllib3>=2, but you have urllib3 1.26.17 which is incompatible.


### Environment

```markdown
- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

We have urllib3 pinned to version 1 because requests depends on openssl (#7573)

For now, pin types-requests in dev-requirements.txt to get it working.

Future: Look into if/when we can unpin urllib3. Based on what I can find it's pin is related to dbt-snowflake so we will want to confirm with the adapters team too. #8790

@emmyoop emmyoop added bug Something isn't working triage labels Oct 6, 2023
@github-actions github-actions bot changed the title [Bug] make dev is broken due to dependency conflict [CT-3189] [Bug] make dev is broken due to dependency conflict Oct 6, 2023
@emmyoop emmyoop self-assigned this Oct 6, 2023
@emmyoop emmyoop added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed triage labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant