Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip profile validation when not necessary #947

Closed
elexisvenator opened this issue Aug 22, 2018 · 2 comments
Closed

Skip profile validation when not necessary #947

elexisvenator opened this issue Aug 22, 2018 · 2 comments
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone

Comments

@elexisvenator
Copy link
Contributor

When running dbt deps, dbt will first call the profile validation code. As dbt deps does not actually use the profile for anything, it should not actually need to validate the profile, or even check if one exists. Other commands such as dbt clean can benefit from this as well.

Example use case:
Calling dbt deps as part of docker build, at which point the environment variables are not yet set (they are only set at runtime)

@drewbanin
Copy link
Contributor

Thanks for the report @elexisvenator!

@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! enhancement New feature or request labels Aug 22, 2018
@drewbanin drewbanin modified the milestone: 0.11.1 - Lucretia Mott Sep 7, 2018
@beckjake
Copy link
Contributor

This was actually fixed as part of #973, I did not realize there was a separate issue for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

No branches or pull requests

3 participants