Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new context invocation class to cache environment variables. #9489

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Use new context invocation class to cache environment variables. #9489

merged 5 commits into from
Feb 2, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jan 30, 2024 •
edited by MichelleArk
Loading

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb marked this pull request as ready for review January 31, 2024 02:55
@peterallenwebb peterallenwebb requested a review from a team as a code owner January 31, 2024 02:55
@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 1, 2024 •
edited
Loading

Changes look good overall. I guess we'll need to release on dbt-common first with the corresponding changes in dbt-labs/dbt-common#52 to see CI passing

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a5d692) 88.04% compared to head (3e8820c) 87.96%.
Report is 1 commits behind head on main.

Files Patch % Lines
core/dbt/logger.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9489      +/-   ##
==========================================
- Coverage   88.04%   87.96%   -0.08%     
==========================================
  Files         167      167              
  Lines       22126    22171      +45     
==========================================
+ Hits        19480    19503      +23     
- Misses       2646     2668      +22
Flag Coverage Δ
integration 85.42% <88.37%> (-0.17%) ⬇️
unit 62.36% <74.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MichelleArk
MichelleArk reviewed Feb 2, 2024
View reviewed changes
core/dbt/task/runnable.py Outdated
@@ -414,6 +416,10 @@ def execute_nodes(self):

return self.node_results

@staticmethod
def _pool_thread_initializer(ci):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is ci the InvocationContext? If so, we can name it ic and type annotate for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes

@peterallenwebb peterallenwebb merged commit ef03ea2 into main Feb 2, 2024
51 checks passed
@peterallenwebb peterallenwebb deleted the paw/env-cache branch February 2, 2024 19:16
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
@dbeatty10 dbeatty10 mentioned this pull request Jul 11, 2024
Open
2 tasks
@aranke aranke mentioned this pull request Jul 15, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleArk MichelleArk MichelleArk approved these changes

@martynydbt martynydbt Awaiting requested review from martynydbt martynydbt is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterallenwebb @MichelleArk