Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording of TestConfigDeprecation is incorrect #9579

Closed
Tracked by #8283
gshank opened this issue Feb 15, 2024 · 0 comments · Fixed by #9823
Closed
Tracked by #8283

Wording of TestConfigDeprecation is incorrect #9579

gshank opened this issue Feb 15, 2024 · 0 comments · Fixed by #9823
Assignees
@aranke
Labels
bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe pre-release Bug not yet in a stable release unit tests Issues related to built-in dbt unit testing functionality
Milestone
v1.8

Comments

@gshank
Copy link
Contributor

gshank commented Feb 15, 2024

Description

The wording of this deprecation refers to 'dbt_project.yml', but this deprecation is also issued for various "tests" configs in schema.yml files, which is really confusing.

Acceptance Criteria

We issue non-confusing messages. There will probably be multiple places with the "tests" config, and we only want to issue one deprecation message, so specifying the file might or might not be a good idea.
@graciegoheen graciegoheen mentioned this issue Feb 20, 2024
Closed
@graciegoheen graciegoheen added pre-release Bug not yet in a stable release bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe labels Feb 20, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 20, 2024
@jtcohen6 jtcohen6 mentioned this issue Feb 23, 2024
Closed
3 tasks
@aranke aranke mentioned this issue Mar 26, 2024
Merged
5 tasks
@dbeatty10 dbeatty10 added the unit tests Issues related to built-in dbt unit testing functionality label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aranke aranke

Labels
bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe pre-release Bug not yet in a stable release unit tests Issues related to built-in dbt unit testing functionality
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Fix info message for TestsConfigDeprecation dbt-labs/dbt-core
5 participants
@gshank @dbeatty10 @aranke @graciegoheen @martynydbt