Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Use consistent secret scrubbing #9987

Closed
2 tasks done
emmyoop opened this issue Apr 19, 2024 · 0 comments · Fixed by #10006
Closed
2 tasks done

[Bug] Use consistent secret scrubbing #9987

emmyoop opened this issue Apr 19, 2024 · 0 comments · Fixed by #10006
Assignees
Labels
bug Something isn't working

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 19, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When secrets are used in the jinja log function, they do not get scrubbed to ***** as they do elsewhere in logs. They appear in the log as the literal text we use to ensure they are not leaked.

To be clear, the secrets are not currently leaked but the behavior is inconsistent with how secrets appear elsewhere in logs.

Expected Behavior

Secrets should display as ***** in logs.

Steps To Reproduce

  1. Define a packages.yml
packages:
    - local: "{{ log(env_var('DBT_ENV_SECRET_MINE'), info = true) }}"  
  1. Run DBT_ENV_SECRET_MINE=abc dbt deps
  2. See in the log
$$$DBT_SECRET_START$$$DBT_ENV_SECRET_MINE$$$DBT_SECRET_END$$$

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@emmyoop emmyoop added the bug Something isn't working label Apr 19, 2024
@emmyoop emmyoop self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant