From 197c05106e35d66cfcedbabdea6c198c2dd2f5e7 Mon Sep 17 00:00:00 2001 From: Jacob Beck Date: Tue, 11 Sep 2018 14:57:23 -0600 Subject: [PATCH] let the empty string mean null --- dbt/clients/agate_helper.py | 12 ++++++------ .../005_simple_seed_test/data/seed_actual.csv | 2 +- test/integration/005_simple_seed_test/seed.sql | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dbt/clients/agate_helper.py b/dbt/clients/agate_helper.py index 4a5d7caad0e..87343ef1a8d 100644 --- a/dbt/clients/agate_helper.py +++ b/dbt/clients/agate_helper.py @@ -4,12 +4,12 @@ DEFAULT_TYPE_TESTER = agate.TypeTester(types=[ agate.data_types.Boolean(true_values=('true',), false_values=('false',), - null_values=('null',)), - agate.data_types.Number(null_values=('null',)), - agate.data_types.TimeDelta(null_values=('null',)), - agate.data_types.Date(null_values=('null',)), - agate.data_types.DateTime(null_values=('null',)), - agate.data_types.Text(null_values=('null',)) + null_values=('null', '')), + agate.data_types.Number(null_values=('null', '')), + agate.data_types.TimeDelta(null_values=('null', '')), + agate.data_types.Date(null_values=('null', '')), + agate.data_types.DateTime(null_values=('null', '')), + agate.data_types.Text(null_values=('null', '')) ]) diff --git a/test/integration/005_simple_seed_test/data/seed_actual.csv b/test/integration/005_simple_seed_test/data/seed_actual.csv index e1bc7fd34da..fc1b8014592 100644 --- a/test/integration/005_simple_seed_test/data/seed_actual.csv +++ b/test/integration/005_simple_seed_test/data/seed_actual.csv @@ -497,5 +497,5 @@ id,first_name,email,ip_address,birthday 496,Brenda,bparkerdr@skype.com,63.232.216.86,1974-05-18 05:58:29 497,Tammy,tmurphyds@constantcontact.com,56.56.37.112,2014-08-05 18:22:25 498,Larry,lhayesdt@wordpress.com,162.146.13.46,1997-02-26 14:01:53 -499,Evelyn,ethomasdu@hhs.gov,6.241.88.250,2007-09-14 13:03:34 +499,,ethomasdu@hhs.gov,6.241.88.250,2007-09-14 13:03:34 500,Paula,pshawdv@networksolutions.com,123.27.47.249,2003-10-30 21:19:20 diff --git a/test/integration/005_simple_seed_test/seed.sql b/test/integration/005_simple_seed_test/seed.sql index d4eea3ae495..0f35d90efa0 100644 --- a/test/integration/005_simple_seed_test/seed.sql +++ b/test/integration/005_simple_seed_test/seed.sql @@ -508,5 +508,5 @@ VALUES (496,'Brenda','bparkerdr@skype.com','63.232.216.86','1974-05-18 05:58:29'), (497,'Tammy','tmurphyds@constantcontact.com','56.56.37.112','2014-08-05 18:22:25'), (498,'Larry','lhayesdt@wordpress.com','162.146.13.46','1997-02-26 14:01:53'), - (499,'Evelyn','ethomasdu@hhs.gov','6.241.88.250','2007-09-14 13:03:34'), + (499,NULL,'ethomasdu@hhs.gov','6.241.88.250','2007-09-14 13:03:34'), (500,'Paula','pshawdv@networksolutions.com','123.27.47.249','2003-10-30 21:19:20');