Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2283] Allow index generation for dbt-core off of branches, not just main #395

Open
emmyoop opened this issue Mar 8, 2023 · 0 comments
Labels
enhancement New feature or request tech_debt

Comments

@emmyoop
Copy link
Member

emmyoop commented Mar 8, 2023

Problem

When there are dbt-docs regressions for previously released versions it is difficult to be able to release just that one fix into dbt-core as a new index.html. The current workflow is to branch off dbt-docs main at the last commit that was moved into the *.latest branch in dbt-core that needs to be backported. Once all dbt-docs changes are made, we need to be able to run the index generation on the exact branch and target the right branch in dbt-core.

Solution

Allow branch to be an input for generate-docs-for-dbt-core.yml and the explicitly checkout that branch. Default to main.

Also allow an input for the target dbt-core branch for the PR. Default to main.

Question: If the branch is not main should the changelog cleanup still happen on the input branch? Probably.

@github-actions github-actions bot changed the title Allow index generation for dbt-core off of branches, not just main [CT-2283] Allow index generation for dbt-core off of branches, not just main Mar 8, 2023
@dbeatty10 dbeatty10 removed the triage label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech_debt
Projects
None yet
Development

No branches or pull requests

2 participants