Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug dbt docs, having a folder with the same name as a macro breaks dbt docs #443

Closed
wants to merge 2 commits into from
Closed

fix bug dbt docs, having a folder with the same name as a macro breaks dbt docs #443

wants to merge 2 commits into from

Conversation

etnnth
Copy link

@etnnth etnnth commented Aug 6, 2023

resolves #442

Description

Fix bug where the docs site crashed when a macro and a folder had the same name. This was due a a key collision in the tree object that was used to create the project structure. The fix is to change the key to be sure that they cannot be identical.

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 6, 2023
@etnnth etnnth changed the title fix key collision between folder and macros fix bug dbt docs Sep 29, 2023
@etnnth etnnth changed the title fix bug dbt docs fix bug dbt docs, having a folder with the same name as a macro breaks dbt docs Sep 29, 2023
@etnnth
Copy link
Author

etnnth commented Oct 15, 2023

@dbeatty10 do I need to do something else to help getting this fix merged?

@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Oct 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Apr 20, 2024
@dbeatty10
Copy link
Contributor

@etnnth -- sorry this got closed as stale. I'm going to re-open it in hopes we can do an initial code review on it.

@dbeatty10 dbeatty10 reopened this Apr 22, 2024
@dbeatty10 dbeatty10 removed the Stale label Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2936] having a folder with the same name as a macro breaks dbt docs
2 participants
@etnnth @dbeatty10