Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/decouple adapters from core #972

Merged
merged 112 commits into from
Jan 25, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

  • implement core / adapters decoupling

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner January 11, 2024 01:20
@cla-bot cla-bot bot added the cla:yes label Jan 11, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

"retry_all": bool(os.getenv("DBT_DATABRICKS_RETRY_ALL", False)),
"connect_retries": 3,
"connect_timeout": 5,
"retry_all": False,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the below conftest fixture I think we don't need to have all these retries anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, this will result in failure in more scenarios, not less. So if we're wrong, the tests simply won't pass. I'm fine with that since we'd be alerted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea most of the time when these fail it's because something is actually broken

"retry_all": bool(os.getenv("DBT_DATABRICKS_RETRY_ALL", False)),
"connect_retries": 3,
"connect_timeout": 5,
"retry_all": False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, this will result in failure in more scenarios, not less. So if we're wrong, the tests simply won't pass. I'm fine with that since we'd be alerted.

def start_databricks_cluster(project, request):
global _DB_CLUSTER_STARTED
profile_type = request.config.getoption("--profile")
with _db_start_lock:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this fixture gets used for all tests, including non-Databricks tests, does this force tests to be run entirely in series?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't since the lock would be released almost instantly (if not databricks or if _DB_CLUSTER_STARTED is True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should only block the first databricks test that runs and even then only if the cluster isn't yet available

@colin-rogers-dbt colin-rogers-dbt merged commit 5d90ff9 into main Jan 25, 2024
16 of 17 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the feature/decouple-adapters-from-core branch January 25, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants